Skip to content

trusted proxies broken in 17.0.5 #20441

Closed

Description

@crackers8199

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. install 17.0.5
  2. set up trusted proxy

Expected behaviour

trusted proxies should work

Actual behaviour

they do not

Server configuration

Operating system:
docker container

Web server:

Database:

PHP version:

Nextcloud version: (see Nextcloud admin page)
17.0.5

Updated from an older Nextcloud/ownCloud or fresh install:
fresh install

Where did you install Nextcloud from:
docker hub

17.0.5 does not seem to work with trusted proxies, and as such the warning on the settings overview page never goes away. i reverted to the 17.0.4 image and it works as expected.

root@4e4cdcb389c0:/var/www/html# sudo -u www-data php occ config:system:set trusted_proxies 0 --value=192.168.64.3
System config value trusted_proxies => 0 set to string 192.168.64.3
root@4e4cdcb389c0:/var/www/html# sudo -u www-data php occ config:system:get trusted_proxies

root@4e4cdcb389c0:/var/www/html# 

if you start with the 17.0.4 image and then upgrade to 17.0.5 after you have a working 17.0.4 install, then it works...but it does not work if you start with a clean install of 17.0.5.

we have a thread on the community open on this...

https://help.nextcloud.com/t/cannot-get-rid-of-the-reverse-proxy-warning/77376/14

Activity

  1. kesselb commented on Apr 12, 2020

    @kesselb
    Contributor

    #20167 is the only change from 17.0.4 to 17.0.5.

  2. kesselb commented on Apr 12, 2020

    @kesselb
    Contributor

    I guess that is related to nextcloud/docker#1010. If you don't set it via environment variable it's null by default.

  3. kesselb commented on Apr 12, 2020

    @kesselb
    Contributor

    Should be fixed by nextcloud/docker#1048. Closing as unrelated to nextcloud/server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions