Skip to content

Adding REST API - #966

Merged
dartcafe merged 21 commits into
masterfrom
rest-poc
Jul 7, 2020
Merged

dartcafe merged 21 commits into
masterfrom
rest-poc

Conversation

@dartcafe

@dartcafe dartcafe commented Jun 13, 2020 •

Copy link
Copy Markdown
Collaborator

added a REST API

  • extracted the BI from the Controllers to a new Services
  • new ApiControllers
  • started documentation

@dartcafe
dartcafe marked this pull request as draft June 13, 2020 07:41
@dartcafe dartcafe linked an issue Jun 13, 2020 that may be closed by this pull request
@dartcafe
dartcafe marked this pull request as ready for review June 20, 2020 13:31
@dartcafe dartcafe changed the title REST POC - initializing with comments Adding REST API Jun 20, 2020

@stefan-niedermann stefan-niedermann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation, this will be very helpful for every 3rd party app integration!

@dartcafe dartcafe added this to the 1.5 milestone Jun 27, 2020
@dartcafe

Copy link
Copy Markdown
Collaborator Author

@v1r0x Would be cool to have this PR reviewed before the other PRs.

@v1r0x v1r0x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except my two small notes :)

Comment thread appinfo/routes.php Resolved
Comment thread docs/API_v1.0.md Resolved
@dartcafe

dartcafe commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator Author

Merge OK after fixes?

@dartcafe
dartcafe requested a review from v1r0x July 7, 2020 15:24
@dartcafe

dartcafe commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator Author

BTW: Some URLs could be optimized too. Will do that in a PR together with the docs

@dartcafe

dartcafe commented Jul 7, 2020 •

Copy link
Copy Markdown
Collaborator Author

Argh. I will merge this. Otherwise my testing instance needs a refresh due to db changes. Fixes should work. I will test this in the master branch afterwards. Sorry for overriding the final review...

@dartcafe
dartcafe merged commit cf3e219 into master Jul 7, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the rest-poc branch July 7, 2020 15:33
@dartcafe dartcafe mentioned this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide proper REST-API documentation

3 participants