Repository navigation
Conversation
stefan-niedermann
previously approved these changes
Jun 20, 2020
stefan-niedermann
left a comment
Member
There was a problem hiding this comment.
Great documentation, this will be very helpful for every 3rd party app integration!
Collaborator
Author
|
@v1r0x Would be cool to have this PR reviewed before the other PRs. |
This was referenced Jul 3, 2020
v1r0x
requested changes
Jul 7, 2020
v1r0x
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, except my two small notes :)
Collaborator
Author
|
Merge OK after fixes? |
Collaborator
Author
|
BTW: Some URLs could be optimized too. Will do that in a PR together with the docs |
Collaborator
Author
|
Argh. I will merge this. Otherwise my testing instance needs a refresh due to db changes. Fixes should work. I will test this in the master branch afterwards. Sorry for overriding the final review... |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a REST API