Skip to content

Don't add empty date option - #961

Merged
dartcafe merged 1 commit into
masterfrom
fix-empty-dateoption
Jun 16, 2020
Merged

dartcafe merged 1 commit into
masterfrom
fix-empty-dateoption

Conversation

@dartcafe

Copy link
Copy Markdown
Collaborator

fix #958

@dartcafe dartcafe added this to the 1.5 milestone Jun 12, 2020
@dartcafe
dartcafe requested a review from v1r0x June 12, 2020 06:51
@dartcafe dartcafe self-assigned this Jun 12, 2020

@v1r0x v1r0x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to disable the OK button at all. But I couldn't find an option for that in the Datepicker docs.
Thus, lgtm 🐧

@dartcafe

Copy link
Copy Markdown
Collaborator Author

Yes. I've gone the easy way.

@dartcafe
dartcafe merged commit 643f0a8 into master Jun 16, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the fix-empty-dateoption branch June 16, 2020 10:06
@dartcafe dartcafe mentioned this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On new page load, when selecting a new datetime for the poll, hitting OK submits datetime of Wed, Dec 31, 1969 4:00 PM

2 participants