Skip to content

fix(filters): respect share download permission in filtered albums - #4034

Merged
GhassenKefi merged 1 commit into
masterfrom
fix/filters-share-download-permission
Oct 29, 2026
Merged

GhassenKefi merged 1 commit into
masterfrom
fix/filters-share-download-permission

Conversation

@GhassenKefi

Copy link
Copy Markdown
Contributor

Filter-based albums resolve their contents by searching the owner's files, which also includes received shares. Exclude files from shares that do not permit downloading when resolving album contents.

Assisted-by: ClaudeCode:claude-opus-4-8

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@GhassenKefi
GhassenKefi requested review from artonge and susnux October 29, 2026 11:21
@GhassenKefi GhassenKefi self-assigned this Oct 29, 2026
@GhassenKefi GhassenKefi added the 3. to review Waiting for reviews label Oct 29, 2026
Filter-based albums resolve their contents by searching the owner's
files, which also includes received shares. Exclude files from shares
that do not permit downloading when resolving album contents.

Assisted-by: ClaudeCode:claude-opus-4-8
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>
@GhassenKefi
GhassenKefi force-pushed the fix/filters-share-download-permission branch from 5b0ed64 to cac9ec1 Compare October 29, 2026 11:43
@GhassenKefi

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Oct 29, 2026
@GhassenKefi

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@GhassenKefi

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@GhassenKefi

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@GhassenKefi
GhassenKefi merged commit 3dc2131 into master Oct 29, 2026
45 checks passed
@GhassenKefi
GhassenKefi deleted the fix/filters-share-download-permission branch October 29, 2026 12:17
@backportbot

backportbot Bot commented Oct 29, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/4034/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cac9ec10

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4034/stable35

Error: Failed to check for changes with origin/stable35: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux

susnux commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

/backport to stable35

@backportbot

backportbot Bot commented Oct 29, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/4034/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cac9ec10

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4034/stable35

Error: Failed to check for changes with origin/stable35: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux

susnux commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

/backport to stable31

@backportbot

backportbot Bot commented Oct 29, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/4034/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cac9ec10

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4034/stable35

Error: Failed to check for changes with origin/stable35: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Oct 29, 2026

Copy link
Copy Markdown

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/4034/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cac9ec10

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4034/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@GhassenKefi

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants