Fix keyboard accessibility - #1236
Merged
Merged
Conversation
CarlSchwan
marked this pull request as draft
July 25, 2022 10:40
CarlSchwan
force-pushed
the
fix/keyboard-accessibility
branch
from
July 25, 2022 10:46
78f273d to
90f9a32
Compare
Member
Sounds like it. |
CarlSchwan
force-pushed
the
fix/keyboard-accessibility
branch
from
July 25, 2022 13:12
90f9a32 to
2fd18b7
Compare
Member
Author
I created nextcloud-libraries/nextcloud-vue#2886 but don't think this should be blocking for this PR (we can adapt to the newer component in another PR) |
CarlSchwan
marked this pull request as ready for review
July 25, 2022 13:25
Member
|
Am I doing something wrong? Neither with notifcation nor without the content is shown to me Without
With notification
|
CarlSchwan
force-pushed
the
fix/keyboard-accessibility
branch
from
July 28, 2022 12:41
2fd18b7 to
fd88239
Compare
Member
Author
fixed now |
nickvergessen
requested changes
Jul 29, 2022
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
nickvergessen
force-pushed
the
fix/keyboard-accessibility
branch
from
July 29, 2022 15:02
0de3128 to
8b7eb8d
Compare
nickvergessen
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.