Skip to content

chore: welcome back webpack - #10482

Merged
ChristophWurst merged 4 commits into
mainfrom
revert/vite
Dec 12, 2024
Merged

ChristophWurst merged 4 commits into
mainfrom
revert/vite

Conversation

@hamza221

@hamza221 hamza221 commented Dec 11, 2024 •

Copy link
Copy Markdown
Contributor

Reverts #9757
Reverts #10403
Reverts #10341

Closes #10427
Closes #10428

@hamza221

Copy link
Copy Markdown
Contributor Author

I'll squash and sign once approved

@GretaD

GretaD commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

how can i test it?

@ChristophWurst

Copy link
Copy Markdown
Member

I've set a PR description to make the objective of this change clear.

@GretaD you should be able to use the file picker again on this branch

@kesselb

kesselb commented Dec 12, 2024 •

Copy link
Copy Markdown
Contributor

I'm getting the error below when running npm install or npm ci:

npm error code 1
npm error path server/apps-extra/mail/node_modules/esbuild
npm error command failed
npm error command sh -c node install.js
npm error server/apps-extra/mail/node_modules/esbuild/install.js:132
npm error     throw new Error(`Expected ${JSON.stringify(versionFromPackageJSON)} but got ${JSON.stringify(stdout)}`);
npm error           ^
npm error
npm error Error: Expected "0.17.18" but got "0.21.5"
npm error     at validateBinaryVersion (server/apps-extra/mail/node_modules/esbuild/install.js:132:11)
npm error     at server/apps-extra/mail/node_modules/esbuild/install.js:285:5
npm error
npm error Node.js v20.18.1

@kesselb

kesselb commented Dec 12, 2024 •

Copy link
Copy Markdown
Contributor

I'm able to install the dependencies with npm update.
This modifies the lockfile (e.g. lockfileVersion 2 => 3, updates a couple of dependencies).

I tested with my locally updated state:

  • Building with prod, dev and watch works
  • Can open the file picker in message view
  • Can open the file picker in composer
  • Opening the file picker trigger a request to lazy load the component
  • The add mail account button trigger a request to lazy load the component
  • CKEditor's toolbar is translated when using german as language1

Footnotes

  1. We have german informal (de) and german formal (de-DE). The translation only works when using the informal version. The problem seems to exist on stable3.7 too, will log a new issue... ↩

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221

Copy link
Copy Markdown
Contributor Author

Footnotes

1. We have german informal (de) and german formal (de-DE). The translation only works when using the informal version. The problem seems to exist on stable3.7 too, will log a new issue... [↩](#user-content-fnref-1-660815b2e3d298086ed630f059106c17)

maybe it's not available at the CKEditor side ? https://ckeditor.com/docs/ckeditor5/latest/getting-started/setup/ui-language.html#list-of-available-professional-translations

@kesselb

kesselb commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Footnotes

1. We have german informal (de) and german formal (de-DE). The translation only works when using the informal version. The problem seems to exist on stable3.7 too, will log a new issue... [↩](#user-content-fnref-1-660815b2e3d298086ed630f059106c17)

maybe it's not available at the CKEditor side ? https://ckeditor.com/docs/ckeditor5/latest/getting-started/setup/ui-language.html#list-of-available-professional-translations

Here's the issue: #10488

@kesselb

kesselb commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Thanks for your quick fix 👍

Seems to work with your latest commit 🙏

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed all 24812 changed lines. Looks good

@ChristophWurst
ChristophWurst merged commit 099e479 into main Dec 12, 2024
@ChristophWurst
ChristophWurst deleted the revert/vite branch December 12, 2024 15:58
@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composer: Add attachment from Files Attachment: Save to Files broken

4 participants