Skip to content

ci: sync workflows with org templates and fix broken jobs - #1425

Open
juliusknorr wants to merge 1 commit into
mainfrom
ci/sync-workflows
Open

juliusknorr wants to merge 1 commit into
mainfrom
ci/sync-workflows

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Sync the workflows with the org templates and fix the jobs that currently fail on every PR.

  • Template sync: icewind1991/nextcloud-version-matrix@v1.3.2 fails its branch lookup and falls back to master. The templates use nextcloud-libraries/nextcloud-version-matrix@v1.3.4. Also pulls in the current action pins, changes-and-matrix jobs, ramsey/composer-install and the new auto-approve logic in update-nextcloud-ocp.yml / npm-audit-fix.yml
  • node.yml renamed to npm-build.yml (the template node.yml is now a failing no-op). Kept without the "Check build changes" step, since js/ and css/ are recompiled by update-node-dist.yml after merge. Summary job is still named node
  • update-nextcloud-ocp-approve-merge.yml removed, folded into update-nextcloud-ocp.yml upstream
  • node-dist-unchanged.yml was an invalid workflow (duplicated steps: key, so runs ended with a workflow file error). Fixed into one job
  • litmus.yml: pinned to ubuntu-24.04. litmus 0.13 ./configure fails on ubuntu-26.04 ("could not find library containing socket") because GCC 15 defaults to C23. CFLAGS=-std=gnu17 would fix configure, but GCC 14+ also turns old-C warnings into errors, so the known-good toolchain is the safer pick
  • dependabot-approve-merge.yml: template version plus continue-on-error on the auto-merge step, which fails with "Pull request is in unstable status" when there are no required checks pending (stable branches)
  • dependabot.yml: ignore typescript majors until typescript-eslint supports TS 7
  • playwright.yml left as is (app-specific, its test job is a required check)

All required checks on main keep their names (eslint, node, php-lint-summary, test-summary, php-cs, phpunit-{oci,pgsql,sqlite,mysql}-summary, test, Block fixup and squash commits).

Unblocks: #1390, #1424, litmus on all PRs to main.

Backports needed: yes. stable32-35 still pin v1.3.2, run litmus on ubuntu-latest and use the old auto-approve workflow, and PRs run the workflows from their base branch. So #1307, #1308, #1387, #1405, #1406 and the red auto-approve runs on stable dependabot PRs only clear after backporting. node-dist-unchanged.yml only exists on stable34/35.

- Sync workflows with nextcloud/.github templates, which switch to
  nextcloud-libraries/nextcloud-version-matrix v1.3.4 (v1.3.2 fails its
  branch lookup and falls back to master)
- Rename node.yml to npm-build.yml, without the build changes check
  since assets are recompiled after merge
- Remove update-nextcloud-ocp-approve-merge.yml, folded into
  update-nextcloud-ocp.yml
- Fix node-dist-unchanged.yml (duplicated steps key, invalid workflow)
- Run litmus on ubuntu-24.04, litmus 0.13 configure fails with GCC 15
- Do not fail dependabot auto-approve when auto-merge cannot be enabled
- Ignore typescript major updates until typescript-eslint supports TS 7

No-test: CI config
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Julius Knorr <jus@bitgrid.net>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant