Skip to content

debt(versions): Remove dependency over \OC\User\User - #2456

Merged
mejo- merged 3 commits into
mainfrom
artonge/debt/remove_oc_user_dep
Nov 16, 2026
Merged

mejo- merged 3 commits into
mainfrom
artonge/debt/remove_oc_user_dep

Conversation

@artonge

@artonge artonge commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@artonge
artonge force-pushed the artonge/debt/remove_oc_user_dep branch 2 times, most recently from 9985089 to 34632f2 Compare May 1, 2026 07:09
artonge and others added 3 commits November 16, 2026 15:37
Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Jonas <jonas@freesources.org>
CollectiveVersionsExpireManager extended the private OC\Hooks\BasicEmitter
to emit enterFolder, deleteVersion and deleteFile hooks. The only listeners
were in the collectives:pages:expire command and were removed in c3eaf8d
long time ago, so the emitted hooks have no consumers.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
CollectivesUserStorage threw the private OC\ForbiddenException, which the
WebDAV layer doesn't handle, so forbidden operations on the collectives
user folder resulted in a 500 response. Throw OCP\Files\ForbiddenException
instead, which is translated into a 403.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the artonge/debt/remove_oc_user_dep branch from 34632f2 to 9827ee1 Compare November 16, 2026 15:17
@mejo-
mejo- marked this pull request as ready for review November 16, 2026 15:17
@mejo- mejo- self-assigned this Nov 16, 2026
@mejo-
mejo- merged commit 3e5512b into main Nov 16, 2026
65 checks passed
@mejo-
mejo- deleted the artonge/debt/remove_oc_user_dep branch November 16, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants