Repository navigation
debt(versions): Remove dependency over \OC\User\User - #2456
Merged
Merged
Conversation
artonge
force-pushed
the
artonge/debt/remove_oc_user_dep
branch
2 times, most recently
from
May 1, 2026 07:09
9985089 to
34632f2
Compare
Signed-off-by: Louis Chmn <louis@chmn.me> Signed-off-by: Jonas <jonas@freesources.org>
CollectiveVersionsExpireManager extended the private OC\Hooks\BasicEmitter to emit enterFolder, deleteVersion and deleteFile hooks. The only listeners were in the collectives:pages:expire command and were removed in c3eaf8d long time ago, so the emitted hooks have no consumers. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
CollectivesUserStorage threw the private OC\ForbiddenException, which the WebDAV layer doesn't handle, so forbidden operations on the collectives user folder resulted in a 500 response. Throw OCP\Files\ForbiddenException instead, which is translated into a 403. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
artonge/debt/remove_oc_user_dep
branch
from
November 16, 2026 15:17
34632f2 to
9827ee1
Compare
mejo-
marked this pull request as ready for review
November 16, 2026 15:17
mejo-
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
November 16, 2026 15:17
mejo-
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.