Skip to content

fix(notification): Make relative action links absolute when preparing - #3124

Merged
szaimen merged 1 commit into
masterfrom
fix/notification-relative-action-links
Nov 4, 2026
Merged

szaimen merged 1 commit into
masterfrom
fix/notification-relative-action-links

Conversation

@szaimen

@szaimen szaimen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Team invitation (and join request) notifications created before #1759 still have relative action links stored in oc_notifications. Since NC 31 the server checks action links on every render and logs:

Link of action is not an absolute URL and does not work in mobile and desktop clients [app: circles, subject: invitation]

Because clients poll notifications regularly, this fills the log. The Accept/Refuse actions on these notifications also don't work in the desktop and mobile clients.

This converts relative links to absolute ones in Notifier::prepareActions(), which fixes existing notifications without a migration.

Backports to stable branches to follow.

🤖 Generated with Claude Code

Notifications created before 0847ec9 still store relative action links.
Since NC 31 the server logs a warning for each of them on every render, and
the actions don't work in the desktop and mobile clients.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen added this to the Nextcloud 36 milestone Nov 3, 2026
@szaimen

szaimen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@szaimen

szaimen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@szaimen

szaimen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@szaimen

szaimen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@szaimen

szaimen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable31

@szaimen
szaimen enabled auto-merge November 3, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants