Repository navigation
fix(notification): Make relative action links absolute when preparing - #3124
Merged
Merged
Conversation
Notifications created before 0847ec9 still store relative action links. Since NC 31 the server logs a warning for each of them on every render, and the actions don't work in the desktop and mobile clients. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
artonge
approved these changes
Nov 3, 2026
szaimen
enabled auto-merge
November 3, 2026 17:41
ArtificialOwl
approved these changes
Nov 4, 2026
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team invitation (and join request) notifications created before #1759 still have relative action links stored in
oc_notifications. Since NC 31 the server checks action links on every render and logs:Because clients poll notifications regularly, this fills the log. The Accept/Refuse actions on these notifications also don't work in the desktop and mobile clients.
This converts relative links to absolute ones in
Notifier::prepareActions(), which fixes existing notifications without a migration.Backports to stable branches to follow.
🤖 Generated with Claude Code