Skip to content

feat: favourite team resources per user - #3079

Open
stediefan wants to merge 1 commit into
masterfrom
feature/3057-team-resource-favourite
Open

stediefan wants to merge 1 commit into
masterfrom
feature/3057-team-resource-favourite

Conversation

@stediefan

Copy link
Copy Markdown
Contributor

Summary

Introduces the ability to favourite team resources for users

Screenshot

image

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@stediefan stediefan added this to the Nextcloud 36 milestone Oct 21, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in 👥 Teams Oct 21, 2026
@stediefan stediefan moved this from Backlog to In progress in 👥 Teams Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@stediefan
stediefan force-pushed the feature/3057-team-resource-favourite branch from 97fefd3 to bb4fa97 Compare October 26, 2026 06:56
Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de>
@stediefan
stediefan force-pushed the feature/3057-team-resource-favourite branch from bb4fa97 to af07585 Compare October 26, 2026 07:01
@stediefan
stediefan marked this pull request as ready for review October 26, 2026 07:08
@stediefan
stediefan requested a review from artonge October 26, 2026 07:08
@stediefan stediefan moved this from In progress to In review in 👥 Teams Oct 26, 2026
Comment thread src/teams/api.ts
* @return Entry ids, first to last
*/
export async function fetchResourceFavorites(teamId: string): Promise<string[]> {
const { data } = await axios.get<OcsResponse<{ favorites: string[] }>>(generateOcsUrl('apps/circles/teams/{circleId}/resource-favorites', { circleId: teamId }))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we return the favorite state when fetching the ressources? This would save one request

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is the issue that not all resources are fetched from the resources request: the team-folder itself and the pages are fetched differently (e.g. pages by wevdav). That would complicate things imho.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that the team folder is fetched with a webdav request that might or might not fail? And if it fails, we do not display it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not quite. The folders are fetched by a separate API endpoint in Circles. The pages within are fetched via WebDAV. And the other Resources are actual Resources. Therefore a favourite state on the resources would not suffice (at least yet).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with #3089 the pages will become resources

@artonge artonge moved this from In review to In progress in 👥 Teams Nov 3, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@stediefan stediefan moved this from In progress to In review in 👥 Teams Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Add ability to favourite resources

3 participants