Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
97fefd3 to
bb4fa97
Compare
Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de>
bb4fa97 to
af07585
Compare
| * @return Entry ids, first to last | ||
| */ | ||
| export async function fetchResourceFavorites(teamId: string): Promise<string[]> { | ||
| const { data } = await axios.get<OcsResponse<{ favorites: string[] }>>(generateOcsUrl('apps/circles/teams/{circleId}/resource-favorites', { circleId: teamId })) |
There was a problem hiding this comment.
Shouldn't we return the favorite state when fetching the ressources? This would save one request
There was a problem hiding this comment.
Currently there is the issue that not all resources are fetched from the resources request: the team-folder itself and the pages are fetched differently (e.g. pages by wevdav). That would complicate things imho.
There was a problem hiding this comment.
Do you mean that the team folder is fetched with a webdav request that might or might not fail? And if it fails, we do not display it?
There was a problem hiding this comment.
No not quite. The folders are fetched by a separate API endpoint in Circles. The pages within are fetched via WebDAV. And the other Resources are actual Resources. Therefore a favourite state on the resources would not suffice (at least yet).
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Introduces the ability to favourite team resources for users
Screenshot
Checklist
3. to review, feature component)stable32)AI (if applicable)