Repository navigation
#2966 fix: reintroduce team-joining and appoval feature - #3018
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
7a711dc to
427340d
Compare
|
/backport to stable35 |
427340d to
e8651da
Compare
Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de> Assisted-by: GitHub Copilot:Claude Opus 5.5 Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de>
e8651da to
655f819
Compare
| try { | ||
| const result = await store.joinTeam(team.id) | ||
| if (result === 'joined') { | ||
| showSuccess(t('circles', 'You have joined the team {circleName}.', { circleName: team.displayName })) |
There was a problem hiding this comment.
No need for a toast in case of success. The updated UI should be enough
| await router.push({ name: 'team', params: { teamId: team.id } }) | ||
| } | ||
| } else { | ||
| showSuccess(t('circles', 'Your request to join this team is pending approval')) |
|
The backport to # Switch to the target branch and update it
git checkout stable35
git pull origin stable35
# Create the new backport branch
git checkout -b backport/3018/stable35
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 655f8197
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3018/stable35Error: Failed to check for changes with origin/stable35: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@stediefan do you need help with the backport? happy to assist |
Summary
fixes #2966 and reintroduces the ability to join teams.
also fixes the approval process.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)