Skip to content

#2966 fix: reintroduce team-joining and appoval feature - #3018

Merged
stediefan merged 1 commit into
masterfrom
task/2966-join-open-teams
Oct 16, 2026
Merged

stediefan merged 1 commit into
masterfrom
task/2966-join-open-teams

Conversation

@stediefan

@stediefan stediefan commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

fixes #2966 and reintroduces the ability to join teams.
also fixes the approval process.

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@stediefan
stediefan force-pushed the task/2966-join-open-teams branch 3 times, most recently from 7a711dc to 427340d Compare October 7, 2026 05:18
@stediefan
stediefan marked this pull request as ready for review October 7, 2026 05:24
@stediefan

Copy link
Copy Markdown
Contributor Author

/backport to stable35

Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de>
Assisted-by: GitHub Copilot:Claude Opus 5.5
Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de>
try {
const result = await store.joinTeam(team.id)
if (result === 'joined') {
showSuccess(t('circles', 'You have joined the team {circleName}.', { circleName: team.displayName }))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a toast in case of success. The updated UI should be enough

await router.push({ name: 'team', params: { teamId: team.id } })
}
} else {
showSuccess(t('circles', 'Your request to join this team is pending approval'))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@stediefan
stediefan merged commit b41b0e9 into master Oct 16, 2026
51 checks passed
@stediefan
stediefan deleted the task/2966-join-open-teams branch October 16, 2026 09:03
@github-project-automation github-project-automation Bot moved this from In review to Done in 👥 Teams Oct 16, 2026
@backportbot

backportbot Bot commented Oct 16, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/3018/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 655f8197

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3018/stable35

Error: Failed to check for changes with origin/stable35: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@pringelmann

Copy link
Copy Markdown
Contributor

@stediefan do you need help with the backport? happy to assist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add ability to join teams

4 participants