Carl/cleanup

[CarlSchwan]

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI

[coderabbitai]

Warning

Review limit reached

@CarlSchwan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dcb2c42b-bc50-464d-83aa-c42ae8e3e371

📥 Commits

Reviewing files that changed from the base of the PR and between 8d193f0 and fa0a327.

📒 Files selected for processing (1)

• tests/psalm-baseline.xml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 91d2d023-494d-4fe0-b993-38e82dac0915

📥 Commits

Reviewing files that changed from the base of the PR and between 7ac3bf5 and 8d193f0.

📒 Files selected for processing (3)

• lib/Middleware/ExAppUiMiddleware.php
• lib/Service/ExAppOccService.php
• tests/psalm-baseline.xml

💤 Files with no reviewable changes (1)

• tests/psalm-baseline.xml

---

📝 Walkthrough

Walkthrough

Middleware methods now explicitly declare their return types. The UI middleware casts preg_replace results to strings. The command configure method declares a void return type. The migration changes the deploy_config operation from changeColumn to modifyColumn while retaining the not-null constraint. The Psalm baseline removes related suppressions.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title "Carl/cleanup" is too generic and does not identify the middleware, migration, or type declaration cleanup.	Use a concise title that identifies the primary change, such as "Add explicit return types and update migration column handling".
Description check	❓ Inconclusive	The description contains only an AI-content checklist and does not explain any change in the pull request.	Add a short summary of the return type updates, migration change, and Psalm baseline cleanup.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a7ba9720-5edb-4690-b520-849a567049de

📥 Commits

Reviewing files that changed from the base of the PR and between b7d4944 and 7ac3bf5.

📒 Files selected for processing (3)

• lib/Middleware/ExAppUIL10NMiddleware.php
• lib/Middleware/ExAppUiMiddleware.php
• lib/Migration/Version2000Date20240120094952.php