Repository navigation
Conversation
Avoid KeyError for absent or already removed options and cover missing, repeated, and empty-name removals with regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an option that was never set, or removing the same option twice, currently raises
KeyError. The method documents removal when an option was previously given and should remain chainable.Use a non-inserting lookup and
pop(..., None)so missing removals are harmless and unrelated options are preserved. Add five test cases for absent keys/parameters, repeated removal, chaining, and empty names. Three of these cases fail on the original implementation.Validation on Windows x64 / Python 3.12:
mypy cmr tests: passed (1.11.2).The test environment used the repository lockfile's requests 2.32.4, urllib3 2.2.3, and vcrpy 6.0.1 versions; no dependency or fixture changes are included.