Repository navigation
Conversation
utils::mask returned a usize, which is only 32-bit wide on those targets. This resulted in incorrect mask values being generated in Float::from_bits (not all 52 bits were covered). Switch it to returning a `u64`, which also lets us drop now-unnecessary casts.
mihaip
added a commit
to mihaip/snow
that referenced
this pull request
Sep 21, 2026
Temporary until nadavrot/arpfloat#19 is merged.
mihaip
added a commit
to mihaip/snow
that referenced
this pull request
Oct 2, 2026
Temporary until nadavrot/arpfloat#19 is merged.
mihaip
added a commit
to mihaip/snow
that referenced
this pull request
Oct 17, 2026
Temporary until nadavrot/arpfloat#19 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils::maskreturned ausize, which is only 32-bit wide on those targets. This resulted in incorrect mask values being generated inFloat::from_bits(not all 52 bits were covered).Switch it to returning a
u64, which also lets us drop now-unnecessary casts.This fixes uses of
arpfloatwhen targeting WebAssembly (and specifically mihaip/infinite-mac#465).