Skip to content

Converter Inheritance Support - #385

Merged
mysticmind merged 3 commits into
mysticmind:masterfrom
Soyvolon:inheritance-update
Jun 19, 2024
Merged

Converter Inheritance Support#385
mysticmind merged 3 commits into
mysticmind:masterfrom
Soyvolon:inheritance-update

Conversation

@Soyvolon

Copy link
Copy Markdown
Contributor

Changes

  • Added additional constructor with parameter (param Assembly[] additionalAssemblies) to the Converter constructor with support for custom converters and converters that inherit from existing converters.
  • Changed all private readonly fields in Converter to protected readonly
  • Changed all public methods in Converter to public virtual
  • Added test class/case for testing the constructor.

Issues

Closes #384

@mysticmind
mysticmind marked this pull request as ready for review June 19, 2024 04:55
@mysticmind
mysticmind merged commit 2e3d52f into mysticmind:master Jun 19, 2024
@mysticmind mysticmind changed the title [Draft] Converter Inheritance Support Converter Inheritance Support Jun 19, 2024
@mysticmind

Copy link
Copy Markdown
Owner

@Soyvolon @abounds-fsp I managed to run through the changes and merge the same 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Classes to Support Customization via Inheritance

3 participants