fix(AppHeaderBanner): add focus-visible styles for keyboard accessibility - #48962
Open
waterWang wants to merge 1 commit into
Open
fix(AppHeaderBanner): add focus-visible styles for keyboard accessibility#48962waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #48959
Adds
:focus-visiblestyles to the announcement banner link inAppHeaderBannerto ensure keyboard users can see where focus is positioned.Changes
:focus-visibleoutline styles to thelinkStyleOverridesinAppHeaderBanner.tsx2pxring with2pxoffset for clear visibility against the blue gradient backgroundBefore
Focusing the announcement banner link via keyboard produced zero visual change — the default browser outline was suppressed with no author-defined replacement.
After
A white outline ring appears around the link when focused via keyboard (
:focus-visible), satisfying WCAG 2.4.7 Focus Visible and 1.4.11 Non-Text Contrast.