fix: reload model after editing YAML config (issue #8647)#8652
Merged
mudler merged 1 commit intoFeb 25, 2026
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Add *model.ModelLoader parameter to EditModelEndpoint - Call ml.ShutdownModel() after saving config to unload the running model - Model will be reloaded on next inference request with new settings (e.g., context_size) - Update route registration to pass ml to EditModelEndpoint Signed-off-by: localai-bot <localai-bot@users.noreply.github.com>
localai-bot
force-pushed
the
fix/issue-8647-reload-model-config
branch
from
da7d6bd to
515eea8
Compare
Collaborator
Author
|
I have added the required DCO sign-off to address the CI failure. The changes are now ready for re-review. |
mudler
approved these changes
Feb 25, 2026
localai-bot
added a commit
to localai-bot/LocalAI
that referenced
this pull request
Mar 25, 2026
…er#8652) fix: reload model configuration after editing (issue mudler#8647) - Add *model.ModelLoader parameter to EditModelEndpoint - Call ml.ShutdownModel() after saving config to unload the running model - Model will be reloaded on next inference request with new settings (e.g., context_size) - Update route registration to pass ml to EditModelEndpoint Signed-off-by: localai-bot <localai-bot@users.noreply.github.com> Co-authored-by: localai-bot <localai-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When changing
context_size(or other runtime settings) in the YAML Configuration Editor via the frontend, the change was saved to the file but not applied to the running model. The model needed to be manually restarted for the new configuration to take effect.Root Cause
The
EditModelEndpointfunction:Preload()- but this only handles downloading/verifying model files, NOT unloading/reloading the actual loaded model processesThe
context_sizeis set when the backend process (llama.cpp, gpt4all, etc.) starts, so changing the YAML doesn't affect the already-loaded backend.Solution
*model.ModelLoaderparameter toEditModelEndpointfunctionml.ShutdownModel(modelName)to unload the running model from memoryCloses #8647