fix: ci poetry venv and pre-commit pyupgrade - #349
Merged
Merged
Conversation
poetry.toml sets virtualenvs.create=false, so pipx poetry installed into the runner's system Python 3.12 and failed uninstalling Debian packages. Force venv creation in CI via POETRY_VIRTUALENVS_CREATE. Drop the poetry cache from release, which never creates a venv.
pyupgrade --py314-plus rewrites the quoted return annotation added in #345, failing pre-commit. The project requires Python 3.14, where annotations are evaluated lazily (PEP 649), so the unquoted form imports fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
fix/ci-poetry-venv, includes its commit.poetry.tomlsetsvirtualenvs.create=false, so poetry installed into the runner's system Python 3.12 and failed. Force venv creation in CI viaPOETRY_VIRTUALENVS_CREATE; drop the unused poetry cache from release.pyupgrade --py314-plusrewrote the quoted return annotation from fix(refusal_classifier): quote self-referential annotation to fix import NameError聽#345. On 3.14 (required by the project) annotations are lazy (PEP 649), so the unquoted form imports fine.Verified locally on 3.14: module import OK,
pytest440 passed / 5 skipped,pre-commit run --all-filesall passed.馃 Generated with Claude Code