Repository navigation
Conversation
kasper93
reviewed
Nov 11, 2026
Member
|
This probably is related to #17719 and also note that |
vrodic
force-pushed
the
mac-media-controls
branch
2 times, most recently
from
November 11, 2026 06:47
932542f to
3ddc44d
Compare
RemoteCommandCenter was always created on macOS. It publishes Now Playing info and, for every loaded file, requests a QuickLook thumbnail to use as cover art, which makes the system thumbnail agent generate and cache thumbnails of everything played. There was no way to turn this off at runtime, since --media-controls was Windows only and --input-media-keys only gates the remote commands. Only create it in initMpv when --media-controls is enabled, after options have been parsed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vrodic
force-pushed
the
mac-media-controls
branch
from
November 11, 2026 06:53
3ddc44d to
2e395d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, RemoteCommandCenter was always created. For every loaded file it requests a QuickLook thumbnail to use as Now Playing cover art, which makes the system thumbnail agent generate and cache thumbnails of everything played. Neither
--media-controls(documented as Windows only) nor--input-media-keyscould turn this off.This creates RemoteCommandCenter in
initMpv, after options are parsed, and only when--media-controlsis enabled. It also updates the option docs and adds an interface-changes note.Tested on macOS (arm64) with the CLI player: with
--media-controls=nothere is no Now Playing activity and no connection tocom.apple.quicklook.ThumbnailsAgent. Withyes(the default) Now Playing works as before. Not tested with libmpv embedders. Sincemedia-controlsdefaults to off for libmpv, they no longer get Now Playing info unless they enable the option.🤖 Generated with Claude Code