Repository navigation
osdep/path-win: expand ~~exe_dir/ on portable mode - #18442
Merged
Merged
Conversation
don't know why it was only expanded on non-portable mode before, but adding this should be fine.
Member
|
I also never understood why |
Contributor
|
Seems OK, but the commit where it was added says that it's for config purposes, and I don't think it's accidental that it's only for non-portable mode - 26fc70d - it could have easily been added next to I do agree it can have value outside of config purpose, but I wonder if there could be some implications we're not aware of currently. |
Member
|
portable mode also have config, and not providing |
Contributor
It would just point to /usr/bin, since portable_config isn't a thing on Linux |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't know why it was only expanded on non-portable mode before, but adding this should be fine.
Closes: #10009
Closes: #18429