match decomposed/precomposed unicode strings with sub-auto=fuzzy #4016

Activity

1. wiiaboo commented on Jan 10, 2017

   

   wiiaboo

   on Jan 10, 2017

   Member

   More actions

   Must be some macOS-only bug, works fine in Windows.
2. ParadiseDS commented on Jan 11, 2017

   

   ParadiseDS

   on Jan 11, 2017

   Last edited by ParadiseDS

   Author

   More actions

   Must be some macOS-only bug, works fine in Windows.

   Do you try to open the video via terminal (maybe cmd in windows? I didn't try mpv in windows..)
   I just found the problem was only triggered via terminal launch. Opening the file in Finder is fine.
3. Akemi commented on Jan 11, 2017

   

   Akemi

   on Jan 11, 2017

   Member

   More actions

   i can't reproduce this. it works via terminal and the bundle here. can you reproduce it with --no-config --sub-auto=fuzzy?
5. ParadiseDS commented on Jan 11, 2017

   

   ParadiseDS

   on Jan 11, 2017 via email

   Author

   More actions

   Yes I can reproduce the problem with the options you mentioned. The log file is on http://sprunge.us/cNGI <http://sprunge.us/cNGI> And by renaming the files to `[.mkv` and `[.ass` the problem is solved. I just found `ぐ.mkv`+ `ぐ.ass` pair was broken as well, and so is any filename contains 'ぐ’. Filename containing some other Hiraganas seems to work well. (I remember it worked last night..maybe I opened the file via Finder by mistake?) And my locale settings is as following, thought they may be related. ``` LANG="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_CTYPE="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_ALL="en_US.UTF-8” ```

   …

   在 2017年1月11日，上午9:38，Akemi ***@***.***> 写道： i can't reproduce this. it works via terminal and the bundle here. can you reproduce it with --no-config --sub-auto=fuzzy? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4016 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADRAPofuai0IkwGdLegVMTYxxmvilW6pks5rRDKEgaJpZM4LgA2h>.
6. ghost added

   os:mac

   on Jan 11, 2017
8. ParadiseDS commented on Jan 11, 2017

   

   ParadiseDS

   on Jan 11, 2017

   Author

   More actions

   So it is a normalization issue, where OSX not only uses non-standard normalization, but also is inconsistent about which form it uses.

   Likely a WONTFIX.

   Sorry to hear that.
   Is there any work around for this issue? As launching mpv via bundle just works while iTerm2.app and terminal.app fail, can the terminal applications behave as Finder do?
9. Akemi commented on Jan 11, 2017

   

   Akemi

   on Jan 11, 2017

   Member

   More actions

   i tested with the same mpv version and set the same locale as you. i am also on the same macOS version, and it still works here. i wonder what else could be different on your system.
10. ParadiseDS commented on Jan 11, 2017

    

    ParadiseDS

    on Jan 11, 2017 via email

    Author

    More actions

    Here I asked one of my colleagues to test and he could exactly reproduce my problem, on the same macOS version. I don't know if other system preference settings like area or lauguage matters. The prior language in `System Preferences > Language & Region` we choose here is Simplified Chinese. From: Akemi Date: 2017-01-11 20:20 To: mpv-player/mpv CC: 小叶子; Author Subject: Re: [mpv-player/mpv] mpv failed to load subtitle file with specific character pair in filename (#4016) i tested with the same mpv version and set the same locale as you. i am also on the same macOS version, and it still works here. i wonder what else could be different on your system. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
11. ParadiseDS

    changed the title [-]mpv failed to load subtitle file with specific character pair in filename[/-] [+]mpv failed to load subtitle file with specific character in filename[/+] on Jan 11, 2017
12. Akemi commented on Jan 11, 2017

    

    Akemi

    on Jan 11, 2017

    Member

    More actions

    tested with that too and still works. here a log. the only things i really noticed, when comparing the logs, is:

    1. your libass is build with harfbuzz, which shouldn't make a difference
    2. my mpv is build with uchardet, which might make the difference here

    maybe give it a try and build mpv with uchardet. if you can't, try this build. if you want to start it from the terminal, right click the bundle and click "Show package Contents", navigate to Contents > MacOS and drag an drop the "mpv" binary into your terminal. in the terminal there should be the path to the binary now and just test it with --no-config and your options again.
13. wiiaboo commented on Jan 11, 2017

    

    wiiaboo

    on Jan 11, 2017

    Member

    More actions

    I don't think uchardet works on filenames, just on subtitle data. @wm4?
16. 22 remaining items

    Load more
17. Akemi

    added

    meta:feature-request

    on Jan 20, 2017
18. Akemi

    changed the title [-]mpv failed to load subtitle file with specific character in filename[/-] [+]match decomposed/precomposed unicode strings with sub-auto=fuzzy[/+] on Jan 20, 2017
19. Akemi

    removed

    os:mac

    on Jan 20, 2017
20. Akemi commented on Jan 20, 2017

    

    Akemi

    on Jan 20, 2017

    Member

    More actions

    i changed the title a bit since this is more like a feature request now.
21. Akemi

    added 3 commits that reference this issue on Jan 25, 2017

    cocoa: consistent normalisation when searching for external files

    ...

    This issue will close once commit 3e5b990 is merged into the 'master' branch.

    3e5b990

    cocoa: consistent normalisation when searching for external files

    ...

    This issue will close once commit f210822 is merged into the 'master' branch.

    f210822

    cocoa: consistent normalisation when searching for external files

    ...

    This issue will close once commit de5a3a9 is merged into the 'master' branch.

    de5a3a9
22. Akemi commented on Jan 25, 2017

    

    Akemi

    on Jan 25, 2017

    Member

    More actions

    #4067 another attempt to fix this. hopefully this time without any drawbacks.
23. Akemi

    added a commit that references this issue on Jan 26, 2017

    cocoa: consistent normalisation when searching for external files

    ...

    This issue will close once commit 66ac354 is merged into the 'master' branch.

    66ac354
24. ParadiseDS commented on Jan 26, 2017

    

    ParadiseDS

    on Jan 26, 2017 via email

    Author

    More actions

    Thanks for your work Akemi!

    …

    在 2017年1月26日，上午4:12，Akemi ***@***.***> 写道： #4067 <#4067> another attempt to fix this. hopefully this time without any drawbacks. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#4016 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADRAPk2hZyuDjKDdrGWeWRf9GTSowgs_ks5rV6zLgaJpZM4LgA2h>.
25. Akemi commented on Jan 29, 2017

    

    Akemi

    on Jan 29, 2017

    Member

    More actions

    just wondering, this worked for you as expected?
26. ParadiseDS commented on Jan 30, 2017

    

    ParadiseDS

    on Jan 30, 2017 via email

    Author

    More actions

    Hello Akemi I’ve tried building from cocoa_decompose_iconv and the build does fix the problem, loading external subs as expected here.

    …

    在 2017年1月30日，上午2:55，Akemi ***@***.***> 写道： just wondering, this worked for you as expected? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#4016 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADRAPjc0YKmX7hsvXImLCr_j5fUp_BMLks5rXOC1gaJpZM4LgA2h>.
27. Akemi

    added a commit that references this issue on Feb 2, 2017

    osx: consistent normalisation when searching for external files

    ...

    This issue will close once commit b451a4a is merged into the 'master' branch.

    b451a4a
28. Akemi

    closed this as completedin #4067on Feb 2, 2017
29. Akemi

    added a commit that references this issue on Feb 2, 2017

    osx: consistent normalisation when searching for external files

    ...

    This issue will close once commit 8bbdece is merged into the 'master' branch.

    8bbdece