Repository navigation
Implement Index and IndexMut traits - #98
Merged
Merged
Conversation
It's useful to have `Index` and `IndexMut` traits implemented if you
want to have code that is generic over indexable containers, such as
this one:
```
fn increment<C>(container: &mut C, index: usize)
where
C: std::ops::IndexMut<usize>,
C::Output: std::ops::AddAssign<i32>,
{
container[index] += 1;
}
```
Having these traits is also consistent with `Vec`, which also
implements them.
Immutable indexing is already tested, but I have added a test for
mutable indexing.
emilio
approved these changes
Oct 7, 2026
emilio
left a comment
emilio
left a comment
Collaborator
There was a problem hiding this comment.
It matches Vec<> so I guess it seems fine. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's useful to have
IndexandIndexMuttraits implemented if you want to have code that is generic over indexable containers, such as this one:Having these traits is also consistent with
Vec, which also implements them.Immutable indexing is already tested, but I have added a test for mutable indexing.