Checks: Persist placeholder warnings to DB - #4499
Open
ayshushus wants to merge 1 commit into
Open
Conversation
eemeli
requested changes
Sep 7, 2026
eemeli
left a comment
eemeli
left a comment
Member
There was a problem hiding this comment.
The fix itself looks fine, but there's a bit of unnecessary feature creep here.
| format = cast(Resource.Format, entity.resource.format) | ||
| errors: list[str] = [] | ||
| warnings: list[str] = [] | ||
| ndb_warnings: list[str] = [] |
Member
There was a problem hiding this comment.
Let's be a little less cryptic and spend a few more characters here.
Suggested change
| ndb_warnings: list[str] = [] | |
| non_db_warnings: list[str] = [] |
Comment on lines
+61
to
+64
| if library not in NON_DB_LIBRARIES: | ||
| log.error( | ||
| f"Discarding failed checks from unknown library {library!r}: {messages}" | ||
| ) |
Member
There was a problem hiding this comment.
This is a bit gratuitous. This never happens, and we're working on refactoring the linting code into moz-l10n, so the changes here are quite unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4364
Placeholder and element warnings from checks (specifically like
Android) were being routed topndbWarnings(non-DB) instead ofpWarnings(stored), causing an issue if the translator "Saves anyway".Split the warning bucket in
custom.pyto separate stored warnings from non-DB warnings.Add regression guard.