Skip to content

Add integration tests for the Home/End keys in the Menu class - #21706

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:test-menu-first-last
Aug 4, 2026
Merged

Add integration tests for the Home/End keys in the Menu class#21706
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:test-menu-first-last

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Follow-up to PR #21690: these tests check that pressing Home/End correctly updates the last focused menu-item index, so that a following ArrowUp/ArrowDown press doesn't move focus to an unexpected menu-item.

Follow-up to PR mozilla#21690: these tests check that pressing Home/End
correctly updates the last focused menu-item index, so that a following
ArrowUp/ArrowDown press doesn't move focus to an unexpected menu-item.
@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (4806d82) to head (12cde32).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21706   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         264      264           
  Lines       66894    66894           
=======================================
  Hits        60229    60229           
  Misses       6665     6665           
Flag Coverage Δ
integrationtest 69.36% <ø> (-0.01%) ⬇️
unittestcli 56.61% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman
calixteman merged commit e57a464 into mozilla:master Aug 4, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants