Skip to content

Shorten the Menu constructor a tiny bit - #21700

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Menu-constructor-shorten
Aug 4, 2026
Merged

Shorten the Menu constructor a tiny bit#21700
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Menu-constructor-shorten

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

The fallback path used when the menuItems aren't provided/correct can be simplified, since the manual loop isn't necessary.

The fallback path used when the `menuItems` aren't provided/correct can be simplified, since the manual loop isn't necessary.
@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (4806d82) to head (1e2c571).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21700      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.02%     
==========================================
  Files         264      264              
  Lines       66894    66890       -4     
==========================================
- Hits        60229    60218      -11     
- Misses       6665     6672       +7     
Flag Coverage Δ
browsertest 66.52% <ø> (+<0.01%) ⬆️
integrationtest 69.34% <100.00%> (-0.03%) ⬇️
unittest 57.88% <ø> (ø)
unittestcli 56.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit b75d2b6 into mozilla:master Aug 4, 2026
16 of 17 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good; thanks!

@Snuffleupagus
Snuffleupagus deleted the Menu-constructor-shorten branch August 4, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants