Repository navigation
Conversation
dannycolin
self-requested a review
September 8, 2026 19:28
Collaborator
By "default container", are you referring to the cookies & site data for regular tabs that aren't in a container? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
Fixes a major UX friction point where users can easily get stuck in cross-container OAuth flows (such as Google Sign-In) because there is no explicit way to clear an "Always open in..." assignment from the popup or page action menu.
This PR adds a "Default Container" option to both the popup
always-open-inmenu and thepageActionmenu. Clicking this option clears the site's container assignment and safely reloads the tab in the default container.Implementation Details:
removeAlwaysOpenInContainer()utility inutils.js.webRequestlistener intercepts the newly created default tab before the assignment is cleared from storage. The rule is now cleanly removed before the new tab is created, and then the success message is routed to the new tab.assignment.test.jsand940.test.jsto account for the new Default Container menu item to ensure tests continue passing.Type of change