RUBY-3429 Retry failed KMS requests - #2907
Merged
Merged
Conversation
jamis
requested changes
Nov 18, 2024
jamis
left a comment
jamis
left a comment
Contributor
There was a problem hiding this comment.
Looks good -- just the one question about integer division around the sleep call.
| while (kms_context = Binding.ctx_next_kms_ctx(self)) do | ||
| begin | ||
| delay = Binding.kms_ctx_usleep(kms_context) | ||
| sleep(delay / 1_000_000) unless delay.nil? |
Contributor
There was a problem hiding this comment.
I think either delay or 1_000_000 needs to be a float here, otherwise it will use integer division. Unless the intention here is to use integer division?
Contributor
Author
There was a problem hiding this comment.
Good catch, thank you! Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.