Repository navigation
fix(review): stop annotated navigation skipping notes drawn outside hunks - #1147
Open
HackAttack wants to merge 1 commit into
Open
HackAttack wants to merge 1 commit into
HackAttack wants to merge 1 commit into
Conversation
…unks
`{`/`}` and `hunk session navigate --next-comment` skipped a note whose
line falls outside every hunk, such as a stored note after a reload
moved the hunks. The diff pane still drew the note in its declared or
gap-owner hunk, but the annotated-hunk index counted only strict range
overlaps, so no navigation stop pointed at it.
The index now resolves each annotation through the same anchor logic the
diff pane draws with, so every drawn note's hunk is a stop.
|
@HackAttack is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
PR author is not in the allowed authors list. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{/}andhunk session navigate --next-commentskipped a note whose line falls outside every hunk, such as a stored note after a reload moved the hunks. The diff pane still drew the note in its declared or gap-owner hunk, but the annotated-hunk index counted only strict range overlaps, so no navigation stop pointed at it.The index now resolves each annotation through the same anchor logic the diff pane draws with, so every drawn note's hunk is a stop.