Repository navigation
fix(session): keep sessions alive while window is suspended - #1134
Open
HackAttack wants to merge 1 commit into
Open
HackAttack wants to merge 1 commit into
HackAttack wants to merge 1 commit into
Conversation
Ctrl-Z stops the whole process group, so the broker heartbeats stop with it while the detached daemon keeps running. The daemon could not tell a SIGSTOPped producer from a dead one and pruned the session after the TTL, so `hunk session` commands failed with "No active Hunk sessions" while the window was backgrounded and again for several seconds after `fg` while the client re-registered. The transport already distinguishes the two cases: a stopped process keeps its socket open, a dead one closes it and the daemon removes the session through the close event immediately. Stale pruning now consults the socket via an optional `isOpen` probe on the peer; a still-open transport is never pruned for silence, and probe-less peers keep the old silence-based TTL.
Contributor
|
PR author is not in the allowed authors list. |
|
@HackAttack is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl-Z stops the whole process group, so the broker heartbeats stop with it while the detached daemon keeps running. The daemon could not tell a SIGSTOPped producer from a dead one and pruned the session after the TTL, so
hunk sessioncommands failed with "No active Hunk sessions" while the window was backgrounded and again for several seconds afterfgwhile the client re-registered.The transport already distinguishes the two cases: a stopped process keeps its socket open, a dead one closes it and the daemon removes the session through the close event immediately. Stale pruning now consults the socket via an optional
isOpenprobe on the peer; a still-open transport is never pruned for silence, and probe-less peers keep the old silence-based TTL.