Skip to content

Added workflow file to trigger CI for testing pull requests - #4805

Open
MatthiasBSchaefer wants to merge 3 commits into
modelica:masterfrom
ltx-simulation:CI_trigger
Open

MatthiasBSchaefer wants to merge 3 commits into
modelica:masterfrom
ltx-simulation:CI_trigger

Conversation

@MatthiasBSchaefer

Copy link
Copy Markdown
Contributor

This workflow acts only as a trigger.
The regression testing for pull requests itself will be performed in a private repository.
This is neccessary to avoid potential security issues and keep the use of commercial tools private.
The workflow is described in https://github.com/modelica/MA-Internal/blob/master/MA-Projects/MAP-LIB/MeetingMinutes/20260714-Monthly/20260714_RegressionTestingCI_Workflow.pdf
As a result, the workflow will approve the pull request or request changes (including links to reports)

@MatthiasBSchaefer MatthiasBSchaefer added the CI Issue that addresses continuous integration label Sep 8, 2026
@beutlich
beutlich removed their request for review September 9, 2026 16:06
@AHaumer
AHaumer requested review from henrikt-ma and maltelenz and removed request for AHaumer September 10, 2026 08:20
@AHaumer

AHaumer commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Since I have no experience with git workflows I'd be glad about reviews from colleagues that have deeper knowledge.
Really a pity that @beutlich refuses to review. Feel free to invite other colleagues for review.

@HansOlsson

Copy link
Copy Markdown
Contributor

I have tried to look at it based on the GitHub documentation, and to me it seems good with some minor comments:

  • It runs for all pull requests, should we limit it to pull requests targeting master and specific maintenance-branches (as the CI cannot run for earlier maintenance levels, right?)
  • Regarding hasLabel, there seems to be two completely different styles for checking labels, this is one of them, and it should work.

However, I'm not an expert regarding the security implications (even if seems they are more of an issue for the LTX-machines).
So, either:

  • I click "accept" with that caveat
  • Since no-one here seems willing to say that they are an expert we hire someone externally to evaluate it

@AnHeuermann AnHeuermann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
No obvious unsafe stuff like leaking secrets to a fork PR.

Dependabot is worth a look. Otherwise someone needs to keep actions up to date manually.

Comment thread .github/workflows/CI_ReSim_trigger.yml Outdated
Comment thread .github/workflows/CI_ReSim_trigger.yml Outdated
Comment thread .github/workflows/CI_ReSim_trigger.yml Outdated
- add trigger for the workflow when labeling the PR
- only run PR testing for PR targeting master or maint-branches
- full-sha for github-script action
@MatthiasBSchaefer

MatthiasBSchaefer commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

@AnHeuermann , @HansOlsson
Thanks for your suggestions.
The latest commit includes:

  • only testing PRs targeting master or maintainace branches
  • trigger workflow also on labeling the PR (with ready_for_ci label)
  • full sha for github_script workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Issue that addresses continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants