Repository navigation
docs(security-advisory): land GHSA fixes through ordinary public PRs - #2886
Merged
Merged
Conversation
Rewrite step 5 of the security-advisory skill to the flow v2.14.0 / 1.0.4 used: review in the private fork, convert the draft card (or file the v1 issue), push the fork branch publicly, open an ordinary PR with normal CI and no ruleset changes, then close the fork PRs unmerged. Step 6 shrinks to updating the already-public issues after publication. Update AGENTS.md's GHSA-draft exception, the release skill's v1 pointer and --advisory note, and the release-notes.mjs header to match. Closes #2880 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the security-advisory procedure updates, which change only documentation and a script header comment.
No open issues 🎉
What changed in this PR
Updates the security-advisory procedure for #2880 so privately developed fixes land through ordinary public PRs, preserving normal CI, required checks, and review without changing branch rulesets.
Changes:
- Moves public issue creation to when the reviewed fix is ready to land, with guidance to remove sensitive details before disclosure.
- Documents public PR landing, closing private-fork PRs unmerged, and releasing every affected line before advisory publication.
- Aligns repository rules and release guidance; updates only the header comment in the release-notes script.
| File | Description |
|---|---|
scripts/release-notes.mjs |
Updates the explanatory comment for advisory fixes landing through public PRs; no runtime changes. |
AGENTS.md |
Aligns public tracking and milestone timing with fix readiness. |
.claude/skills/security-advisory/SKILL.md |
Replaces private-fork merging with the ordinary public PR procedure and simplifies post-publication tracking. |
.claude/skills/release/SKILL.md |
Updates advisory release-note guidance and the v1 landing procedure. |
Review effort: Balanced
Member
Author
|
Copilot review loop closed: round 1 was clean (no inline comments, no headline findings, no suppressed comments), so per pr-flow 7c no further round was requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2880
Rewrites the
security-advisoryskill's landing step to the flow v2.14.0 / 1.0.4 actually used: fixes are developed and reviewed in the advisory's private fork, then land through an ordinary public PR, with normal CI, the requiredDCO/buildchecks, the Copilot loop and no ruleset changes.Changes
.claude/skills/security-advisory/SKILL.mdv2/fix/<N>-<slug>/v1/fix/<N>-<slug>Closes #Nand follow/pr-flow/pr-flownote, and step 1/3/4 pointers are updated to match.AGENTS.md: the GHSA-draft exception now says the card becomes public tracking when the reviewed fix is ready to land, not once the advisory is published. TheIncominginvariant's milestone note is updated the same way..claude/skills/release/SKILL.md: the v1 merge-order pointer and the--advisorynote no longer describe fork merges.scripts/release-notes.mjs: the header comment is updated to match (comment only).The skill's frontmatter description is unchanged, so the listing and the eval cases are unaffected.
🤖 Generated with Claude Code