fix(client): fully collapse Output Schema and Meta panels in ToolsTab - #1295
SarthakB11 wants to merge 1 commit into
Conversation
|
Closing: v1 is deprecated. Thank you for this contribution, and apologies for the long wait for a response. v1 will receive security fixes only. We reviewed every open v1 PR for security impact before closing — see the backlog triage in #1819 — and a small number were retained for a final If the underlying problem still exists in v2, we'd genuinely like to know. Please open an issue describing it against v2. Note that we accept external contributions as issues rather than pull requests — maintainers handle design and implementation through a prompt-driven workflow. See Thanks again for taking the time to contribute to the Inspector. |
Summary
The Output Schema and Meta panels in the tool detail view kept rendering their JSON body inside a clipped scroll well (
max-h-[8rem] overflow-y-auto) when "collapsed", so a chunk of the panel content stayed on screen and the toggle didn't really collapse anything. The issue's screenshot shows this clearly.This PR conditionally renders each body only when the corresponding
isOutputSchemaExpanded/isMetadataExpandedflag is true. Collapsed state now shows just the header row and the Expand button, matching the user expectation in #928.The fix targets V1 (
client/src/components/ToolsTab.tsx); the issue's screenshot is from the current V1 UI even though the issue carries thev2label.Fixes #928
Test plan
npm run prettier-fixcleanclient/src/components/__tests__/ToolsTab.test.tsx, so no new test was added.