Skip to content

fix(client): fully collapse Output Schema and Meta panels in ToolsTab - #1295

Closed
SarthakB11 wants to merge 1 commit into
modelcontextprotocol:v1/mainfrom
SarthakB11:fix/issue-928
Closed

SarthakB11 wants to merge 1 commit into
modelcontextprotocol:v1/mainfrom
SarthakB11:fix/issue-928

Conversation

@SarthakB11

Copy link
Copy Markdown

Summary

The Output Schema and Meta panels in the tool detail view kept rendering their JSON body inside a clipped scroll well (max-h-[8rem] overflow-y-auto) when "collapsed", so a chunk of the panel content stayed on screen and the toggle didn't really collapse anything. The issue's screenshot shows this clearly.

This PR conditionally renders each body only when the corresponding isOutputSchemaExpanded / isMetadataExpanded flag is true. Collapsed state now shows just the header row and the Expand button, matching the user expectation in #928.

The fix targets V1 (client/src/components/ToolsTab.tsx); the issue's screenshot is from the current V1 UI even though the issue carries the v2 label.

Fixes #928

Test plan

  • npm run prettier-fix clean
  • Manual: connect to the Everything server in UI mode, open a tool with an output schema, toggle Expand/Collapse on both the Output Schema and Meta panels. Collapsed state now shows only the header.
  • No existing test asserted collapsed-DOM contents in client/src/components/__tests__/ToolsTab.test.tsx, so no new test was added.

@cliffhall
cliffhall changed the base branch from main to v1/main July 28, 2026 03:05
@cliffhall

cliffhall commented Jul 31, 2026

Copy link
Copy Markdown
Member

Closing: v1 is deprecated.

Thank you for this contribution, and apologies for the long wait for a response.

v1 will receive security fixes only. We reviewed every open v1 PR for security impact before closing — see the backlog triage in #1819 — and a small number were retained for a final 1.0.5 patch release. This one is a functionality, compatibility, or cleanup change rather than a vulnerability fix, so it is being closed unmerged. This is not a judgment on the quality of the work — it's a consequence of the branch it targets being frozen.

If the underlying problem still exists in v2, we'd genuinely like to know. Please open an issue describing it against v2. Note that we accept external contributions as issues rather than pull requests — maintainers handle design and implementation through a prompt-driven workflow. See CONTRIBUTORS.md.

Thanks again for taking the time to contribute to the Inspector.

@cliffhall cliffhall closed this Jul 31, 2026
@cliffhall cliffhall added the closed-v1-deprecated Closed: v1 is deprecated and accepting security fixes only label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-v1-deprecated Closed: v1 is deprecated and accepting security fixes only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand/Collapse should fully collapse panel

2 participants