Repository navigation
Contracts & Harnesses for byte_add, byte_offset, and byte_offset_from - #103
Merged
tautschnig merged 27 commits intoDec 3, 2024
Merged
Conversation
danielhumanmod
changed the title
byte_add, byte_offset, and byte_offset_from
danielhumanmod
marked this pull request as ready for review
October 9, 2024 23:48
QinyuanWu
suggested changes
Oct 10, 2024
zhassan-aws
reviewed
Oct 31, 2024
Author
|
Thanks for your suggestion @zhassan-aws! I've updated the code in the latest commit based on your comments. I’d appreciate it if you could take a look when you have a chance. |
zhassan-aws
reviewed
Nov 6, 2024
zhassan-aws
reviewed
Nov 9, 2024
QinyuanWu
reviewed
Nov 12, 2024
danielhumanmod
force-pushed
the
daniel/byte_operation
branch
from
November 13, 2024 07:20
69d7751 to
505f90b
Compare
Author
|
Hi @zhassan-aws , thanks for the review and suggestions. I have updated the code based on the comments, fix the unnecessary assume proof harness, using |
zhassan-aws
approved these changes
Nov 13, 2024
celinval
reviewed
Nov 13, 2024
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Please replace kani::requires and kani::ensures by safety::requires and safety::ensures. Thanks!
zhassan-aws
reviewed
Nov 14, 2024
celinval
reviewed
Nov 15, 2024
celinval
reviewed
Nov 19, 2024
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Looks good. Can you please add harnesses for the dangling pointers cases?
Member
|
@danielhumanmod could you resolve the conflicts? |
Author
Hi @feliperodri , I have solved the conflicts in latest commit, thanks for reminding that |
…nmod/verify-rust-std into daniel/byte_operation
Author
|
Thanks for the clarification @zhassan-aws ! I have updated the code based on the comments, appreciate any further or review that might need @zhassan-aws @celinval |
tautschnig
reviewed
Dec 3, 2024
tautschnig
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces function contracts and proof harness for the NonNull pointer in the Rust core library. Specifically, it verifies three new APIs—
byte_offset,byte_add, andbyte_offset_fromwith Kani. These changes enhance the functionality of pointer arithmetic and verification for NonNull pointers.Changes Overview:
Covered APIs:
NonNull::byte_add: Adds a specified byte offset to a pointer.NonNull::byte_offset: Allows calculating an offset from a pointer in bytes.NonNull::byte_offset_from: Calculates the distance between two pointers in bytes.Proof harness:
non_null_byte_add_proofnon_null_byte_offset_proofnon_null_byte_offset_from_proofTowards #53
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.