Skip to content

_fail tests should fail if compilation fails #338

Description

@vecchiot-aws

The test at src/test/cbmc/DynTrait/main_fail.rs uses _VERIFIER_expect_fail instead of __VERIFIER_expect_fail, causing it to have a rust compile error.

I expect it went by unnoticed because we (accidentally?) left in the _fail suffix, when really it shouldn't fail, and we don't distinguish between compilation failure and verification failure.

Activity

  1. avanhatt commented on Jul 20, 2021

    @avanhatt
    Contributor

    Oh oh, we should totally distinguish between compilation and verification failures (I thought we did, unless a test was _ignore or _fixme).

  2. avanhatt commented on Jul 21, 2021

    @avanhatt
    Contributor

    Fixing this actual test in #342, but let's use this issue to track failing for _fail compilation errors?

  3. changed the title [-]Test `src/test/cbmc/DynTrait/main_fail.rs` uses wrong name for `__VERIFIER_expect_fail`.[/-] [+]`_fail` tests should fail if compilation fails[/+] on Jul 21, 2021
  4. self-assigned this
    on Jul 21, 2021
  5. bdalrhm commented on Jul 21, 2021

    @bdalrhm
    Contributor

    You're both right. We don't currently check for the kind of errors we get from tests. I happen to need this feature for the dashboard as well. So, I will make it a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions