Skip to content

perf-benchcomp CI fails when pushing a new release #2744

Description

@adpaco

Proposed change: Do not run the perf-benchcomp when pushing a release tag.

Motivation: perf-benchcomp jobs get triggered after pushing a release tag and they fail with some error that I don't understand. It doesn't make sense to run perf-benchcomp in CI anyway because the candidate commit will have already done it.

I was surprised to find that the CI job failed when doing the 0.36.0 release (job here). Then I check what happened during the 0.35.0 release and saw the same here (job here).

Activity

  1. added
    [C] InternalTracks some internal work. I.e.: Users should not be affected.
    on Sep 7, 2023
  2. tautschnig commented on Sep 7, 2023

    @tautschnig
    Member

    The root cause of the problem is that github.event.before isn't set for new branches, and likely the same is true for tags. The fix should likely be that we remove

        tags:
          - kani-*
    

    from .github/workflows/bench.yml. We still have the performance comparison on the merge into main anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [C] InternalTracks some internal work. I.e.: Users should not be affected.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions