Skip to content

2021 week 26: rebase off upstream #247

Description

@adpaco
No description provided.

Activity

  1. self-assigned this
    on Jun 22, 2021
  2. adpaco commented on Jun 30, 2021

    @adpaco
    ContributorAuthor

    While rebasing we get a conflict with one of the issue templates: .github/ISSUE_TEMPLATE/library_tracking_issue.md
    Action taken: Remove that file.

    Then we get another conflict in src/tools/compiletest/src/header.rs, where a call to iter_header uses different arguments (we edited this function in #168). Action taken: Replace old call with new one.

  3. adpaco commented on Jun 30, 2021

    @adpaco
    ContributorAuthor

    The previous action did not work. It seems like this commit has changed the way in which tests are marked as "ignored" (this was done in the from_reader impl. of EarlyProps) so I will have to figure out the best way to do this for RMC.

  4. adpaco commented on Jul 2, 2021

    @adpaco
    ContributorAuthor

    Tried again.

    This time, I have accepted the changes in the from_reader impl. of EarlyProps. This removed a change we made in #168 that marked tests as "to-ignore" based on their name. I added an equivalent change in that same commit. Then continued the rebase without any more problems.

  5. adpaco commented on Jul 2, 2021

    @adpaco
    ContributorAuthor

    The regression completes successfully. Candidate branch is main-153-2021-07-02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Z-Sync UpstreamFetch changes from rustc repository. Old Rebase

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions