Skip to content

Can we remove "assertion failed" from successful assertions? #189

Description

@avanhatt

When viewing a CBMC trace from RMC, a user might see something like this:

[main.assertion.1] line 28 assertion failed: std_string == \"1\": FAILURE
[main.assertion.2] line 30 assertion failed: weird_string == \"w\": SUCCESS

The top assertion is failing and the bottom is provably true, but both have assertion failed. I think this is just an artifact of how Rust proper prints assertions; it would be nice to remove this for CBMC usability.

Activity

  1. added
    [E] User ExperienceAn UX enhancement for an existing feature. Including deprecation of an existing one.
    on Jun 9, 2021
  2. adpaco commented on Jun 11, 2021

    @adpaco
    Contributor

    Yes, I think these come specifically from compiler/rustc_middle/src/mir/mod.rs.

    It is true that it may be confusing at times but RMC has nothing to do with this: the assertion text comes from MIR, the verification output comes from CBMC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

[E] User ExperienceAn UX enhancement for an existing feature. Including deprecation of an existing one.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions