📦 Package: Bump chokidar from 4 to 5

[JoshuaKGoldberg]

Feature Request Checklist

• I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
• I have searched for related issues and issues with the faq label, but none matched my issue.
• I want to provide a PR to resolve this

Overview

Mocha currently relies on an old major version of chokidar:

mocha/package.json

Line 100 in 7f9ed1f

"chokidar": "^4.0.1",

Suggested Solution

chokidar@5.0.0 is the latest. It'd be nice to bump to that, so users aren't stuck on a dep that's >=1 major version behind.

Looking at package sizes:

• https://packagephobia.com/result?p=chokidar@4.0.3: chokidar@4.0.3 is 251kb publish / 303kb install
• https://packagephobia.com/result?p=chokidar@5.0.0: chokidar@5.0.0 is 80.1kb publish / 102kb install

https://github.com/paulmillr/chokidar/releases/tag/5.0.0

I set up a quick node_modules/ size comparison on https://github.com/JoshuaKGoldberg/repros/tree/mocha-chokidar-5. Without any other devDependencies, the node_modules size drops from 8.1M to 8.0M. See: #5587

Alternatives

This isn't critical and I don't think we need to do it. But it's nice ecosystem cleanup in general.

I don't know of popular alternatives to chokidar and haven't looked for them. That can be a separate issue if there's notable improvement to be had IMO.

Additional Info

chokidar@5 raised the minimum supported Node.js version from 14.16.0 to 20.19.0. That's the require(esm) minimum that Mocha 12 targets. Since that we're merging Mocha 12 commits in, this issue isn't blocked.

[mark-wiemer]

It feels like just yesterday we upgraded from Chokidar 3 :D

Doesn't seem like there are huge changes in 4->5 like there were from 3->4, so +1 from me :)

[jedwards1211]

Looks like Chokidar v5 is ESM only, not a big problem though, we would just have to use a dynamic import('chokidar') in watch-run.js

[JoshuaKGoldberg]

Even better, Mocha 12 can use ESM. #5477

[jedwards1211]

Oh are y'all planning to rewrite everything to use ESM before tackling this?

[JoshuaKGoldberg]

No, since require(esm) is intentionally in the version range 12 supports now (which is why it can use ESM). But ESM is definitely on the eventual plan for Mocha 12: #5400. Hopefully soon!!

[jedwards1211]

Oh, sorry I didn't read that portion of OP. I didn't realize they backported that to Node 20, interesting

[lennonnikolas]

It seems upgrading to v5 from v4 has no conflicting dependencies and tests today run the same as they did when I just upgraded. I am doing a more thorough sweep but it seems there are no breaking changes from chokidar v4 to chokidar v5. I believe the only issue would be the require import that needs to be ESM friendly.

If you are all rewriting to ESM then perhaps turbowatch or parcel watcher. I would vote for the latter because it would give you performances benefits but with slightly more complex setup which could be evaluated during the rewrite.