solver: ensure each ref in the result map is evaluated - #4544
Merged
Merged
Conversation
jedevc
marked this pull request as draft
January 10, 2024 18:10
This comment was marked as outdated.
This comment was marked as outdated.
There was a typo in d709afd. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
fix-each-ref-evaluate
branch
from
January 11, 2024 11:26
77e7c00 to
cb7d240
Compare
Member
Author
|
Added a test. Note that the fix is for a panic - a frontend could cause buildkit to deref a nil pointer. |
jedevc
marked this pull request as ready for review
January 11, 2024 11:26
tonistiigi
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a reasonably significant typo in
d709afd(#3137), yikes.Came across this while working in the area 😱 Slightly terrifying, I clearly wasn't playing close attention 😢
I don't think this is on a critical code-path anywhere, doing
Evaluateon a frontend provided result was designed to be used in docker/buildx#1197, but I don't think ever became relied-upon functionality.