Repository navigation
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
milas
approved these changes
Oct 27, 2023
milas
left a comment
milas
left a comment
Contributor
There was a problem hiding this comment.
I'm not actually an approver here but LGTM
Member
|
@milas reviewing is open to everyone (and always appreciated!) I have a "green check", because I have "owner" status in this org, but technically not a maintainer of this repository either 😅 |
thaJeztah
requested changes
Oct 31, 2023
| google.golang.org/protobuf v1.30.0 | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20230711160842-782d3b101e98 | ||
| google.golang.org/grpc v1.58.3 | ||
| google.golang.org/protobuf v1.31.0 |
Member
There was a problem hiding this comment.
Commit message of the first commit looks to be incorrect, as this is updating protobuf to v1.31.0
FWIW, I also have these as part of my (still in draft) PR; if you prefer, I can also extract the first few commits from that one to a separate PR;
| // Code generated by protoc-gen-go. DO NOT EDIT. | ||
| // versions: | ||
| // protoc-gen-go v1.30.0 | ||
| // protoc-gen-go v1.31.0 |
Member
There was a problem hiding this comment.
This should probably be in the same commit as the protobuf update (perhaps move that commit separate?)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4385
github.com/containerd/containerdfull diff: containerd/containerd@v1.7.7...v1.7.8
fixes #4373 (containerd/containerd#9299)
google.golang.org/grpcfull diff: grpc/grpc-go@v1.56.3...v1.58.3
google.golang.org/protobuffull diff: protocolbuffers/protobuf-go@v1.30.0...v1.31.0
update containerd binary in dockerfile as well