Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: truePre-merge checks:
|
gmegidish
force-pushed
the
fix/ipad-landscape-square-screen
branch
from
November 11, 2026 20:05
8d443b0 to
b72cd7d
Compare
…ys icons out in its square
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113. Rebased onto #107.
On iPadOS 15, SpringBoard reports a square frame in landscape (1133×1133 on iPad mini 6).
device.inforeturned it as the screen size, and the touch and dump geometry took the portrait width from it, so.landscapeLefttaps on the home screen landed 389 points off.The main display size is now measured once from an XCTest screenshot.
UIScreencan't be used: the runner has no launch screen, so it runs letterboxed and reports a legacy size (768×1024 on iPad, 320×480 on iPhone). #107's interface orientation still decides portrait vs landscape; this replaces its three reads of SpringBoard's frame (device.info, the dump's device frame,springboardToInterface) with the measured size. The foldable secondary-display path is unchanged.Verification
device.info= 1133×1133; tapping Contacts at its visible position does nothing, adding 389 to y opens it.