Deep source modeling (phase 1) - #14130
Open
payamsash wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
you can test it with this small code snippet: |
Contributor
|
Thank you @payamsash! I ran you test code snippet using a cerebellar surface for |
drammock
reviewed
Aug 5, 2026
| FIFF.FIFFV_MNE_SURF_LEFT_HEMI = 101 | ||
| FIFF.FIFFV_MNE_SURF_RIGHT_HEMI = 102 | ||
| FIFF.FIFFV_MNE_SURF_MEG_HELMET = 201 # Use this irrespective of the system | ||
| FIFF.FIFFV_MNE_SURF_SUBCORTICAL_ID_BASE = 1000 # + aseg value, e.g. hippocampus |
Member
There was a problem hiding this comment.
additions to the FIFF standard need to go in https://github.com/mne-tools/fiff-constants. Presumably this would go here-ish:
Contributor
Author
There was a problem hiding this comment.
Done, see this PR. I also added a temp one here: mne/_fiff/tests/test_constants.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
First phase of #14097, also see #6784
What does this implement/fix?
adds
setup_subcortical_source_spacewhich should/will support bothlabel(aseg) andsurface(e.g coming from CBM).Additional information
This is just a Proof-of-concept with
samplesubject.