Skip to content

Do not cache failed distributed backend initialization #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 2 commits into from
Oct 1, 2026
Merged

Do not cache failed distributed backend initialization #4558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fba80f
fix register_group caching
ronaldmannak Sep 24, 2026
1cf5984
clear JACCL environment
ronaldmannak Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions mlx/distributed/distributed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,11 @@ get_backends() {
}

Group register_group(std::shared_ptr<detail::GroupImpl> group, std::string bk) {
auto& backends = get_backends();
if (group == nullptr) {
group = std::make_shared<detail::EmptyGroup>();
} else {
backends.insert({"any", group});
return Group(std::make_shared<detail::EmptyGroup>());
}
auto& backends = get_backends();
backends.insert({"any", group});
backends.insert({std::move(bk), group});
return Group(group);
}
Expand Down
10 changes: 10 additions & 0 deletions python/tests/ring_test_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ def test_groups(self):
with self.assertRaises(RuntimeError):
sub = world.split(world.rank() % 2)

def test_strict_init_after_fallback(self):
with mlx_tests.scoped_env(
JACCL_IBV_DEVICES=None,
MLX_IBV_DEVICES=None,
):
self.assertEqual(mx.distributed.init(backend="jaccl").size(), 1)

with self.assertRaises(RuntimeError):
mx.distributed.init(backend="jaccl", strict=True)

def test_all_reduce_extra(self):
world = mx.distributed.init()
dtypes = [
Expand Down