[FeliGame]

Proposed changes

Fix 4061

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING document
• I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
• I have added tests that prove my fix is effective or that my feature works
• I have updated the necessary documentation (if needed)

[zcbenz]

I can't merge this until @JamesPriceZV verifies it.

[zcbenz]

The original issue was really a minor issue and the fix is risky on the other hand, since it is difficult to verify whether it works and whether it breaks, I'm going to close this.

[reiterate-app]

I got bit by this too. Would it be possible to do a smaller fix?

Scatter::eval_gpu already handles the equivalent idx_ndim == 0 case by padding rather than touching set_vector_bytes globally:

mlx/mlx/backend/metal/indexing.cpp

Lines 411 to 417 in 59d600b

	if (idx_ndim == 0) {
	// Add a 0 in idx_shapes and strides to avoid the missing buffer binding
	// error in the metal API.
	idx_shapes.push_back(0);
	idx_strides.push_back(0);
	idx_contigs.push_back(false);
	}

Would it be possible to do the same thing here?

[zcbenz]

@reiterate-app looks good to me.