(Feat) Initialise table properly even if db file is corrupted. - #654
Merged
Jason Johnston (jasonjoh) merged 1 commit intoNov 13, 2025
Conversation
Matthew Lim (matthew-lim-matthew-lim)
requested a review
from a team
as a code owner
November 8, 2025 08:02
Jason Johnston (jasonjoh)
approved these changes
Nov 13, 2025
Member
Jason Johnston (jasonjoh)
merged commit Nov 13, 2025
054df8b
into
microsoftgraph:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the table sql table isn't created properly, then the program will fail because
ensureDatabase()will think that the table already exists because the database already exists.This is highly prone to failure, because when the authentication isn't completed successfully, it can create a database that doesn't have a table.
The improvement is to use a
CREATE TABLE IF NOT EXISTSsql statement so that the table can be created, even if the database exists without a sql table.