Skip to content

fix: show max while picking multiple groups #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nickii Miaro (Mnickii) merged 1 commit into from
Sep 11, 2024
Merged

fix: show max while picking multiple groups #3289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/mgt-components/src/graph/graph.groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ export const findGroups = async (

filterQuery = filterQuery ? `${filterQuery} and ` : '';
for (const filter of filterGroups) {
batch.get(filter, `/groups?$filter=${filterQuery + filter}`, validGroupQueryScopes);
const fullUrl = `/groups?$filter=${filterQuery + filter}&$top=${top}`;
Comment thread
Mnickii marked this conversation as resolved.
batch.get(filter, fullUrl, validGroupQueryScopes);
}

try {
Expand Down
5 changes: 5 additions & 0 deletions stories/components/peoplePicker/peoplePicker.properties.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,11 @@ export const pickMultipleGroups = () => html`
<!-- group-type can be "any", "unified", "security", "mailenabledsecurity", "distribution" -->
`;

export const pickMultipleGroupsShowMax = () => html`
<mgt-people-picker type="group" group-type="unified,security,mailenabledsecurity" show-max="3"></mgt-people-picker>
<!-- group-type can be "any", "unified", "security", "mailenabledsecurity", "distribution" -->
`;

export const pickPeople = () => html`
<mgt-people-picker type="person"></mgt-people-picker>
<!-- type can be "any", "person", "group" -->
Expand Down