This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Fix Merge error - #322
Merged
Merged
Conversation
malxau-msft
approved these changes
May 9, 2022
Contributor
|
Thanks for promptly checking and following up on this. I'm reflecting on how we could have prevented it - do you have suggestions? (There always seems to be a general problem in code reviews where changes are made that aren't as thoroughly tested as the original, so code at the end of a review is worse than at the start...) |
Contributor
Author
|
It was my bad. I was so sure, everything was merged, and didn't run it again..... and it was late yesterday The general problem with Winfile is, that it lacks an automated regression test. But this will not be solved here anymore, so we have to be very careful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.