Repository navigation
Re-enable official signing validation - #16364
Jakub Jareš (nohwnd) merged 6 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR re-enables signing validation in the official Azure DevOps pipeline configuration, aligning the build validation checks with the current Arcade SDK setup and the intent of issue #15593.
Changes:
- Replaced the temporary
enableSigningValidation: falseoverride withenableSigningValidation: truein the official pipeline post-build template parameters. - Removed the “temporary skip” comment tied to the prior infra workaround.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The cab is signed by Microsoft, but SignCheck reads the signature offset and size from the wrong offsets in the cabinet reserved area and reports every signed cab as unsigned. Tracked by dotnet/arcade#17362, remove the exclusion once the fix flows in. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/SignCheckExclusionsFile.txt:9
- The exclusion pattern is just the filename (
IntelliTraceCollection.cab), which will exclude any file with that name anywhere in the validation scan. Since the failure is for a specific path inside the nupkg, narrow the glob to that package path to avoid masking future issues where anotherIntelliTraceCollection.cabmight legitimately need validation.
IntelliTraceCollection.cab;;Signed by Microsoft, SignCheck misparses signed cabs, dotnet/arcade#17362
azure-pipelines-official.yml:370
- The PR description says "Validation remains enabled and no exclusion was added", but this change set introduces a SignCheck exclusions file to bypass a known SignCheck false-negative. Please update the PR description (or adjust the change) so the PR narrative matches what's being merged.
- template: eng/common/templates-official/post-build/post-build.yml@self
parameters:
enableSigningValidation: true
So whoever deletes the file knows what to close. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
eng/SignCheckExclusionsFile.txt:9
- The comment references closing issue
#16389, but this PR (and the linked issue in the description) is about#15593. Keeping the wrong issue number here will cause confusion when someone later cleans up the exclusion.
;; Delete this file once the Arcade version in global.json contains the fix, and close #16389.
|
this needs fix in arcade that we did just today. so maybe in a week. |
…ficial-signing-validation
The Arcade fix dotnet/arcade#17363 is in 11.0.0-beta.26421.2, which main now consumes, so SignCheck reads the cab signature from the correct reserved fields and the exclusion is no longer needed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Exclusion removed. The Arcade fix (dotnet/arcade#17363 — Read the cab signature from the correct reserved fields) shipped in Closes microsoft/vstest#16389 — Remove the IntelliTraceCollection.cab signing validation exclusion once the Arcade fix flows in. 🤖 |
Re-enable signing validation in the official pipeline now that the repository uses the newer Arcade SDK.
The first official run, build 3048377, failed signing validation on exactly one file out of 2223:
Microsoft.TestPlatform.18.11.0-preview-26414-18.nupkg/tools/net462/Common7/IDE/CommonExtensions/Microsoft/IntelliTrace/IntelliTraceCollection.cabThat cab is signed by Microsoft, SignCheck just reads it wrong. The per-cabinet reserved area of a cab signed by signtool starts with a
0x00100000header, and the signature offset and size follow it. SignCheck skips the header and reads the offset from+0and the size from+4, so it computes1048576 + 2844171 = 3892747for a file that is 2854539 bytes, the bounds check fails, and the cab is reported as unsigned. Reading the correct fields the signature is the last 10368 bytes and decodes to:Get-AuthenticodeSignatureon the same file reportsValid,Signature verified.Filed as dotnet/arcade#17362, fixed in dotnet/arcade#17363.
Official validation with a temporary
eng/SignCheckExclusionsFile.txtin place: build 3050909 is green, all four stages succeeded.One file excluded, nothing unsigned, the skipped count is unchanged from the failing run.
The exclusion is gone again. The Arcade fix shipped in
11.0.0-beta.26421.2, whichmainpicked up in microsoft/vstest#16368 — Update dependencies from dotnet/arcade, so SignCheck reads the cab signature correctly and the cab is validated like every other file. This branch has been merged withmainso it builds against that Arcade version.Fixes #15593
Fixes #16389
🤖