Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public FilterExpressionWrapper(string filterString, FilterOptions? options)
// Property value regex is only supported for fast filter,
// so we ignore it if no fast filter is constructed.

// TODO: surface an error message to suer.
// TODO: surface an error message to user.
var regexString = options?.FilterRegEx;
if (!regexString.IsNullOrEmpty())
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private static void ApplyOverrideToCurrentProcess(CultureInfo language, Action<C
{
return new CultureInfo(dotnetCliLanguage);
}
catch (CultureNotFoundException) { }
catch (CultureNotFoundException) { /* Culture not available on this system — fall back to default. */ }
}

// VSLANG=<lcid> is set by VS and we respect that as well so that we will respect the VS
Expand All @@ -67,8 +67,8 @@ private static void ApplyOverrideToCurrentProcess(CultureInfo language, Action<C
{
return new CultureInfo(vsLcid);
}
catch (ArgumentOutOfRangeException) { }
catch (CultureNotFoundException) { }
catch (ArgumentOutOfRangeException) { /* Invalid culture value — fall back to default. */ }
catch (CultureNotFoundException) { /* Culture not available on this system — fall back to default. */ }
}

return null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ private void CollectDumpAndAbortTesthost()
}
catch (InvalidOperationException)
{
// Process may have already exited — safe to ignore.
}
}
catch (Exception ex)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ public bool TryGetExitCode(object? process, out int exitCode)
}
catch (InvalidOperationException)
{
// Process may have already exited — exit code unavailable.
}

exitCode = 0;
Expand Down Expand Up @@ -301,6 +302,7 @@ public void TerminateProcess(object? process)
}
catch (InvalidOperationException)
{
// Process may have already exited — exit code unavailable.
}
}

Expand Down
Loading