Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
// this whole thing is complicated and depends on versions of OS and the target runtime
// keeping this for later
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class BlameDataCollectorTests : AcceptanceTestBase
{
public const string NETCOREANDFX = "net462;net472;net8.0";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public enum SettingsType
[TestClass]
//Code coverage only supported on windows (based on the message in output)
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class CodeCoverageTests : CodeCoverageAcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DataCollectionTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests.DataCollectorAttachmentsProcessorsFactoryTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DataCollectorAttachmentsProcessorsFactoryTests : AcceptanceTestBase
{
private readonly DataCollectorAttachmentsProcessorsFactory _dataCollectorAttachmentsProcessorsFactory = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DataCollectorTestsCoverlets : IntegrationTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
public class DebugAssertTests : AcceptanceTestBase
{
[TestMethod]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
// this is core only, there is nothing we can do about TPDebug.Assert crashing the process on framework
[NetCoreTargetFrameworkDataSource(useDesktopRunner: false)]
public void RunningTestWithAFailingDebugAssertDoesNotCrashTheHostingProcess(RunnerInfo runnerInfo)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[TestCategory("Windows-Review")]
// TODO: but where are some tests? :D
public class DeprecateExtensionsPathWarningTests : AcceptanceTestBase
{
private readonly IList<string> _adapterDependencies;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DifferentTestFrameworkSimpleTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[TestCategory("Windows")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DisableAppdomainTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DiscoveryTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DotnetArchitectureSwitchTestsWindowsOnly : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
[TestClass]
// On Linux/Mac we don't download the same .NET SDK bundles
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DotnetHostArchitectureVerifierTests : IntegrationTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
/// Running dotnet test + csproj and using MSBuild for the output.
/// </summary>
[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DotnetTestMSBuildOutputTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class DotnetTestTests : AcceptanceTestBase
{
private static string GetFinalVersion(string version)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class EventLogCollectorTests : AcceptanceTestBase
{
// Fails randomly https://ci.dot.net/job/Microsoft_vstest/job/master/job/Windows_NT_Release_prtest/2084/console
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class ExecutionTests : AcceptanceTestBase
{
//TODO: It looks like the first 3 tests would be useful to multiply by all 3 test frameworks, should we make the test even more generic, or duplicate them?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class ExecutionThreadApartmentStateTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class FilePatternParserTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class FrameworkTests : AcceptanceTestBase
{

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
[TestClass]
// this is tested only on .NET Framework
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
Comment thread
nohwnd marked this conversation as resolved.
public class ListExtensionsTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class LoggerTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class MultitargetingTestHostTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
[TestClass]
// monitoring the processes does not work correctly
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class PlatformTests : AcceptanceTestBase
{
/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class PortableNugetPackageTests : AcceptanceTestBase
{
private static string s_portablePackageFolder = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class PostProcessingTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class ProcessesInteractionTests : AcceptanceTestBase
{
/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class RecursiveResourcesLookupTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class ResultsDirectoryTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
[TestClass]
// monitoring the processes does not work correctly
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class RunsettingsTests : AcceptanceTestBase
{
#region Runsettings precedence tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public class SelfContainedAppTests : AcceptanceTestBase
{
[TestMethod]
[TestCategory("Windows-Review")]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
[NetCoreTargetFrameworkDataSourceAttribute(useDesktopRunner: false)]
public void RunningApplicationThatIsBuiltAsSelfContainedWillNotFailToFindHostpolicyDll(RunnerInfo runnerInfo)
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System.Runtime.InteropServices;

using Microsoft.VisualStudio.TestTools.UnitTesting;

namespace Microsoft.TestPlatform.AcceptanceTests;

public class SkipIOutOfProcessTestOnNetFrameworkConditionAttribute : ConditionBaseAttribute
{
private readonly bool _include;

public SkipIOutOfProcessTestOnNetFrameworkConditionAttribute() : base(ConditionMode.Include)
{
_include = !RuntimeInformation.FrameworkDescription.StartsWith(".NET Framework");
IgnoreMessage = "Test was skipped to avoid duplication of the same out-of-process tests between .NET and .NET Framework.";
}

public override string GroupName => "tfm";

public override bool IsConditionMet => _include;
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class TelemetryTests : AcceptanceTestBase
{
private const string TELEMETRY_OPTEDIN = "VSTEST_TELEMETRY_OPTEDIN";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class TestCaseFilterTests : AcceptanceTestBase
{
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[SkipIOutOfProcessTestOnNetFrameworkCondition]
public class TestPlatformNugetPackageTests : CodeCoverageAcceptanceTestBase
{
private static string s_nugetPackageFolder = string.Empty;
Expand Down